From 87edf8cfad9795222f5e0b9693ff039f1ba3e181 Mon Sep 17 00:00:00 2001 From: Olivers Vitins Date: Sat, 4 May 2024 21:55:04 +0300 Subject: [PATCH] fix(changelog): wrong semver sequence generation (#21) now made ascending with "Unreleased" on top --- src/commands/changelog.ts | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/src/commands/changelog.ts b/src/commands/changelog.ts index b26d472..c9c8669 100644 --- a/src/commands/changelog.ts +++ b/src/commands/changelog.ts @@ -20,7 +20,7 @@ along with RCZ. If not, see . import { Command } from "commander"; import simpleGit from "simple-git"; import { CommitStack } from "../types"; -import { sort } from "semver"; +import { gt, sort } from "semver"; const command = new Command("changelog") .alias("ch") @@ -113,7 +113,17 @@ const command = new Command("changelog") lastTag = tag; } - parsedCommitStacks = parsedCommitStacks.reverse(); + // Might be confusing so I will leave mdn docs here + // https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/sort + parsedCommitStacks = parsedCommitStacks.sort((a, b) => { + if (a.version === unreleased) { + return -1; + } else if (b.version === unreleased) { + return 1; + } else { + return gt(a.version, b.version) ? -1 : 1; + } + }); if (lastOnly) { parsedCommitStacks = [parsedCommitStacks[0]];