From 139695edb875ca89e7a3a8cb017da853199525fc Mon Sep 17 00:00:00 2001
From: Vadim <korobeinikovv@mail.ru>
Date: Fri, 22 Jan 2021 20:57:08 +0300
Subject: [PATCH] Code cleanup

---
 src/Arrow/Arrow.stories.js                   |  2 +-
 src/Arrow/Arrow.svelte                       |  7 ++--
 src/Carousel/Carousel.svelte                 | 25 ++++++------
 src/Carousel/CarouselView.svelte             |  3 +-
 src/Carousel/CarouselViewCustomArrows.svelte |  3 +-
 src/Carousel/CarouselViewCustomDots.svelte   |  3 +-
 src/Dot/Dot.stories.js                       |  2 +-
 src/Dots/Dots.stories.js                     |  2 +-
 src/direction.js                             |  2 +
 src/stories/Button.stories.js                | 29 --------------
 src/stories/Button.svelte                    | 42 --------------------
 src/stories/button.css                       | 30 --------------
 12 files changed, 28 insertions(+), 122 deletions(-)
 create mode 100644 src/direction.js
 delete mode 100644 src/stories/Button.stories.js
 delete mode 100644 src/stories/Button.svelte
 delete mode 100644 src/stories/button.css

diff --git a/src/Arrow/Arrow.stories.js b/src/Arrow/Arrow.stories.js
index fae6d53..ae6e312 100644
--- a/src/Arrow/Arrow.stories.js
+++ b/src/Arrow/Arrow.stories.js
@@ -1,7 +1,7 @@
 import Arrow from './Arrow.svelte';
 
 export default {
-  title: 'Arrow',
+  title: 'Default Components/Arrow',
   component: Arrow,
   argTypes: {
     onClick: { action: 'onClick' }
diff --git a/src/Arrow/Arrow.svelte b/src/Arrow/Arrow.svelte
index e3d28ac..5a908fc 100644
--- a/src/Arrow/Arrow.svelte
+++ b/src/Arrow/Arrow.svelte
@@ -1,8 +1,9 @@
 <script>
+  import { NEXT, PREV } from '../direction'
   /**
    * Indicates direction of the arrow ('next', 'prev')
    */
-  export let direction = 'next'
+  export let direction = NEXT
 </script>
 
 <div
@@ -11,8 +12,8 @@
 >
   <i
     class="arrow"
-    class:next={direction === 'next'}
-    class:prev={direction === 'prev'}
+    class:next={direction === NEXT}
+    class:prev={direction === PREV}
   ></i>
 </div>
 
diff --git a/src/Carousel/Carousel.svelte b/src/Carousel/Carousel.svelte
index 132f3e8..72954fc 100644
--- a/src/Carousel/Carousel.svelte
+++ b/src/Carousel/Carousel.svelte
@@ -11,6 +11,7 @@
   } from '../utils/size'
   import Dots from '../Dots/Dots.svelte'
   import Arrow from '../Arrow/Arrow.svelte'
+  import { NEXT, PREV } from '../direction'
 
   /**
    * Enable Next/Prev arrows
@@ -50,7 +51,7 @@
   /**
    * Auto play change direction ('next', 'prev')
    */
-  export let autoplayDirection = 'next'
+  export let autoplayDirection = NEXT
 
   /**
    * Current page indicator dots
@@ -61,16 +62,16 @@
   let pagesCount = 0
   let pageWidth = 0
   let offset
-  let contentContainerElement
-  let innerContentContainerElement
+  let pageWindow
+  let pagesElement
 
   const unsubscribe = store.subscribe(value => {
     currentPageIndex = value.currentPageIndex
   })
 
   function applySlideSizes() {
-    const children = innerContentContainerElement ? innerContentContainerElement.children : []
-    pageWidth = contentContainerElement.clientWidth
+    const children = pagesElement ? pagesElement.children : []
+    pageWidth = pageWindow.clientWidth
 
     const slidesCount = children.length
     pagesCount = getPagesCount({ slidesCount, slidesToShow })
@@ -87,8 +88,8 @@
 
   function applyAutoplay() {
     const autoplayDirectionFnDescription = {
-      'next': showNextPage,
-      'prev': showPrevPage
+      [NEXT]: showNextPage,
+      [PREV]: showPrevPage
     }
     let interval
     if (autoplay) {
@@ -146,28 +147,28 @@
   <div class="carousel-container">
     {#if arrows}
       <slot name="prev" {showPrevPage}>
-        <div class="side-container">
+        <div class="arrow-container">
           <Arrow direction="prev" on:click={showPrevPage} />
         </div>
       </slot>
     {/if}
     <div
       class="content-container"
-      bind:this={contentContainerElement}
+      bind:this={pageWindow}
     >
       <div
         style="
           transform: translateX({offset}px);
           transition-duration: {speed}ms;
         "
-        bind:this={innerContentContainerElement}
+        bind:this={pagesElement}
       >
         <slot></slot>
       </div>
     </div>
     {#if arrows}
       <slot name="next" {showNextPage}>
-        <div class="side-container">
+        <div class="arrow-container">
           <Arrow direction="next" on:click={showNextPage} />
         </div>
       </slot>
@@ -212,7 +213,7 @@
     transition-timing-function: ease-in-out;
     transition-property: transform;
   }
-  .side-container {
+  .arrow-container {
     height: 100%;
     padding: 5px;
     box-sizing: border-box;
diff --git a/src/Carousel/CarouselView.svelte b/src/Carousel/CarouselView.svelte
index c1294d7..fc57a52 100644
--- a/src/Carousel/CarouselView.svelte
+++ b/src/Carousel/CarouselView.svelte
@@ -1,5 +1,6 @@
 <script>
   import Carousel from './Carousel.svelte'
+  import { NEXT } from '../direction'
 
   /**
    * Enable Next/Previos arrows
@@ -39,7 +40,7 @@
   /**
    * Auto play change direction ('next', 'prev')
    */
-  export let autoplayDirection = 'next'
+  export let autoplayDirection = NEXT
 
   /**
    * Current page indicator dots
diff --git a/src/Carousel/CarouselViewCustomArrows.svelte b/src/Carousel/CarouselViewCustomArrows.svelte
index 5b730e9..715bc52 100644
--- a/src/Carousel/CarouselViewCustomArrows.svelte
+++ b/src/Carousel/CarouselViewCustomArrows.svelte
@@ -1,5 +1,6 @@
 <script>
   import Carousel from './Carousel.svelte'
+  import { NEXT } from '../direction'
 
   /**
    * Enable Next/Previos arrows
@@ -39,7 +40,7 @@
   /**
    * Auto play change direction ('next', 'prev')
    */
-  export let autoplayDirection = 'next'
+  export let autoplayDirection = NEXT
 
   /**
    * Current page indicator dots
diff --git a/src/Carousel/CarouselViewCustomDots.svelte b/src/Carousel/CarouselViewCustomDots.svelte
index 8d51c5a..8a951a9 100644
--- a/src/Carousel/CarouselViewCustomDots.svelte
+++ b/src/Carousel/CarouselViewCustomDots.svelte
@@ -1,5 +1,6 @@
 <script>
   import Carousel from './Carousel.svelte'
+  import { NEXT } from '../direction'
 
   /**
    * Enable Next/Previos arrows
@@ -39,7 +40,7 @@
   /**
    * Auto play change direction ('next', 'prev')
    */
-  export let autoplayDirection = 'next'
+  export let autoplayDirection = NEXT
 
   /**
    * Current page indicator dots
diff --git a/src/Dot/Dot.stories.js b/src/Dot/Dot.stories.js
index 1b828d0..56b0844 100644
--- a/src/Dot/Dot.stories.js
+++ b/src/Dot/Dot.stories.js
@@ -1,7 +1,7 @@
 import DotView from './DotView.svelte';
 
 export default {
-  title: 'Dot',
+  title: 'Default Components/Dot',
   component: DotView
 };
 
diff --git a/src/Dots/Dots.stories.js b/src/Dots/Dots.stories.js
index 70434c1..ac52a01 100644
--- a/src/Dots/Dots.stories.js
+++ b/src/Dots/Dots.stories.js
@@ -1,7 +1,7 @@
 import DotsView from './DotsView.svelte';
 
 export default {
-  title: 'Dots',
+  title: 'Default Components/Dots',
   component: DotsView
 };
 
diff --git a/src/direction.js b/src/direction.js
new file mode 100644
index 0000000..c3cc9cc
--- /dev/null
+++ b/src/direction.js
@@ -0,0 +1,2 @@
+export const PREV = 'prev'
+export const NEXT = 'next'
diff --git a/src/stories/Button.stories.js b/src/stories/Button.stories.js
deleted file mode 100644
index 7cb63bb..0000000
--- a/src/stories/Button.stories.js
+++ /dev/null
@@ -1,29 +0,0 @@
-import Button from './Button.svelte';
-
-export default {
-  title: 'Example/Button',
-  component: Button,
-  argTypes: {
-    label: { control: 'text' },
-    primary: { control: 'boolean' },
-    backgroundColor: { control: 'color' },
-    size: {
-      control: { type: 'select', options: ['small', 'medium', 'large'] },
-    },
-    onClick: { action: 'onClick' },
-  },
-};
-
-const Template = ({ onClick, ...args }) => ({
-  Component: Button,
-  props: args,
-  on: {
-    click: onClick,
-  },
-});
-
-export const Primary = Template.bind({});
-Primary.args = {
-  primary: true,
-  label: 'Button',
-};
diff --git a/src/stories/Button.svelte b/src/stories/Button.svelte
deleted file mode 100644
index ee2d74d..0000000
--- a/src/stories/Button.svelte
+++ /dev/null
@@ -1,42 +0,0 @@
-<script>
-  import './button.css';
-  import { createEventDispatcher } from 'svelte';
-  /**
-   * Is this the principal call to action on the page?
-   */
-  export let primary = false;
-
-  /**
-   * What background color to use
-   */
-  export let backgroundColor;
-  /**
-   * How large should the button be?
-   */
-  export let size = 'medium';
-  /**
-   * Button contents
-   */
-  export let label = '';
-
-  let mode = primary ? 'storybook-button--primary' : 'storybook-button--secondary';
-
-  let style = backgroundColor ? `background-color: ${backgroundColor}` : '';
-
-  const dispatch = createEventDispatcher();
-
-  /**
-   * Optional click handler
-   */
-  function onClick(event) {
-    dispatch('click', event);
-  }
-</script>
-
-<button
-  type="button"
-  class={['storybook-button', `storybook-button--${size}`, mode].join(' ')}
-  {style}
-  on:click={onClick}>
-  {label}
-</button>
diff --git a/src/stories/button.css b/src/stories/button.css
deleted file mode 100644
index dc91dc7..0000000
--- a/src/stories/button.css
+++ /dev/null
@@ -1,30 +0,0 @@
-.storybook-button {
-  font-family: 'Nunito Sans', 'Helvetica Neue', Helvetica, Arial, sans-serif;
-  font-weight: 700;
-  border: 0;
-  border-radius: 3em;
-  cursor: pointer;
-  display: inline-block;
-  line-height: 1;
-}
-.storybook-button--primary {
-  color: white;
-  background-color: #1ea7fd;
-}
-.storybook-button--secondary {
-  color: #333;
-  background-color: transparent;
-  box-shadow: rgba(0, 0, 0, 0.15) 0px 0px 0px 1px inset;
-}
-.storybook-button--small {
-  font-size: 12px;
-  padding: 10px 16px;
-}
-.storybook-button--medium {
-  font-size: 14px;
-  padding: 11px 20px;
-}
-.storybook-button--large {
-  font-size: 16px;
-  padding: 12px 24px;
-}