Commit Graph

5 Commits

Author SHA1 Message Date
Ryan Gossiaux
39a8b57c36 Fix implementation of #78
Brain fart when writing and testing the first attempt.
I can only actually reproduce the underlying issue in the REPL so I haven't confirmed that this fixes it.
2022-03-06 23:57:32 -08:00
Ryan Gossiaux
fada4f28a5 Move the portal root to the bottom of the target after initial render
Fixes #78
2022-03-06 22:58:18 -08:00
Ryan Gossiaux
b18fd2093b Manually clean up <Portal> on destroy
Fixes #68

In some cases, when Svelte sees a parent and a child, it will detach the parent and assume that this suffices to detach the child. However, the <Portal> moves elements around in the DOM, so this assumption does not always hold. We need to make sure we detach the portal element ourselves.
2022-02-27 15:24:14 -08:00
Ryan Gossiaux
6d2aa60d22 Use new TS option to preserve imports in tests
These assertions were here to prevent imports (needed for svelte-inine-compile) from being removed.
2022-01-17 23:59:29 -05:00
Ryan Gossiaux
839bb55e40 Add Portal tests 2021-12-30 17:31:16 -10:00